-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button to display raw transaction JSON for addresses and amounts #131
Conversation
for this task "Raw transaction - add a button on each model to show the raw trx, in jason? (for advanced users)" is there more trx places to add this that aren't in wallet? i thought maybe in spend funds |
@dangershony the balance is in satoshi (right?), do we want to change that? |
} | ||
|
||
@if (showRawTransactionModal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this location for the html by convention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Responding a bit late haha, happy to be back!
I took the convention from here:
https://blog.samferree.dev/basics-in-blazor-modal
if you prefer, I can move it to the top of the file or create a component for the modal (it can be much better if you can think of another place we could use the component) .
no its fine to be in satoshi because its a technical view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but please remove the changes to the other file
Als there are conflicts I suggest make a new PR and copy the relevant parts? |
# Conflicts: # src/Angor/Client/Pages/Investor.razor # src/Angor/Client/Pages/Wallet.razor
done |
|
||
@if (showRawTransactionModal) | ||
{ | ||
<div class="modal-wrapper"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could become a component in the next PR.
No description provided.