Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to display raw transaction JSON for addresses and amounts #131

Merged
merged 10 commits into from
Nov 4, 2024

Conversation

itailiors
Copy link
Collaborator

No description provided.

@itailiors
Copy link
Collaborator Author

for this task "Raw transaction - add a button on each model to show the raw trx, in jason? (for advanced users)"

is there more trx places to add this that aren't in wallet? i thought maybe in spend funds

@itailiors itailiors marked this pull request as ready for review August 3, 2024 19:00
@itailiors
Copy link
Collaborator Author

@dangershony the balance is in satoshi (right?), do we want to change that?
also should it popup a password for this?
image

}

@if (showRawTransactionModal)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this location for the html by convention?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responding a bit late haha, happy to be back!

I took the convention from here:
https://blog.samferree.dev/basics-in-blazor-modal
if you prefer, I can move it to the top of the file or create a component for the modal (it can be much better if you can think of another place we could use the component) .

@dangershony
Copy link
Member

@dangershony the balance is in satoshi (right?), do we want to change that? also should it popup a password for this? image

no its fine to be in satoshi because its a technical view

Copy link
Member

@dangershony dangershony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please remove the changes to the other file

@dangershony
Copy link
Member

Als there are conflicts I suggest make a new PR and copy the relevant parts?

# Conflicts:
#	src/Angor/Client/Pages/Investor.razor
#	src/Angor/Client/Pages/Wallet.razor
@itailiors
Copy link
Collaborator Author

Als there are conflicts I suggest make a new PR and copy the relevant parts?

done

@dangershony
Copy link
Member

This PR is fine but what I meant with the task is to show the trx that is about to be published to the blockchain

For example a button here

image

So do it in a new PR and I will push this one, also it would be nice to have that for the other send popups


@if (showRawTransactionModal)
{
<div class="modal-wrapper">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could become a component in the next PR.

@dangershony dangershony merged commit 9fc82a3 into main Nov 4, 2024
3 checks passed
@dangershony dangershony deleted the show-raw-transaction-json branch November 4, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants